Fix clearTaskInstances API: Restore include_past/future support on UI by nothingmin · Pull Request #54416 · apache/airflow

nothingmin · 2025-08-12T14:37:18Z

This PR resolves the issue reported in #54134, where attempting to clear task instances from the Airflow UI using both dag_run_id and include_past/include_future resulted in a 400 error. This prevented users from clearing past or future task instances via the UI, which was possible in previous Airflow versions.

With this fix:

The API now correctly allows the use of include_past/include_future together with dag_run_id, as long as the DAG run has a valid logical_date (i.e., for scheduled DAG runs).
For manually triggered DAG runs (where logical_date is None), the API still returns a 400 error to protect against accidental clearing of unrelated task instances—preventing the original bug from resurfacing.

closes: #54134

boring-cyborg · 2025-08-12T14:37:22Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

pierrejeambrun

Nice thanks.

A few comments to address before we can merge.

Also I just started the CI and it will need fixing (code formatting etc...)

airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py

airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_task_instances.py

nothingmin · 2025-08-20T16:41:13Z

@pierrejeambrun
Thanks for the review!
I’ve addressed all the feedback
All review comments should now be resolved

pierrejeambrun

Can you please fix the CI?

Tested locally, looks good. Just a few things to adjust, we can merge then.

airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_task_instances.py

airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py

pierrejeambrun · 2025-09-04T15:04:18Z

While it should be like this after the clearing request:

pierrejeambrun · 2025-09-04T15:07:23Z

Issue here #55267

boring-cyborg · 2025-09-04T15:58:33Z

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

github-actions · 2025-09-04T15:59:26Z

Backport failed to create: v3-0-test. View the failure log Run details

Status	Branch	Result
❌	v3-0-test

You can attempt to backport this manually by running:

cherry_picker f5d0b17 v3-0-test

This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

…apache#54416)

pierrejeambrun · 2025-09-04T16:11:37Z

Manual backport #55272

…#54416) (#55272) Co-authored-by: Gwak Beomgyu <67548026+nothingmin@users.noreply.github.com>

…apache#54416) * Fix clearTaskInstances API: Restore include_past/include_future support on UI * style: fix formatting * chore: fix typo * chore: remove comment * chore: fix comment DX to TX * refactor: remove verbose handling future or past * refactor: remove verbose handling future or past * refactor: use hardcoded test result * fix(test_task_instances.py): correct test comment * fix(test_task_instances.py): fix typo * fix(test_task_instances.py): fix typo * fix(task_instances.py): make sure start_date, end_date to None * fix(task_instances.py): fix inaccurate response * fix(task_instances.py): fix inaccurate response --------- Co-authored-by: bggwak <bggwak@hyundai.com>

nothingmin requested review from bugraoz93, ephraimbuddy, jason810496, pierrejeambrun, rawwar and shubhamraj-git as code owners August 12, 2025 14:37

boring-cyborg bot added the area:API Airflow's REST/HTTP API label Aug 12, 2025

pierrejeambrun reviewed Aug 20, 2025

View reviewed changes

nothingmin force-pushed the fix/54134 branch from ce1beec to cd630e7 Compare August 20, 2025 16:06

nothingmin requested a review from pierrejeambrun August 21, 2025 11:13

nothingmin force-pushed the fix/54134 branch from 5717959 to 2234c01 Compare August 23, 2025 09:24

pierrejeambrun added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Sep 2, 2025

pierrejeambrun added this to the Airflow 3.0.7 milestone Sep 2, 2025

pierrejeambrun reviewed Sep 2, 2025

View reviewed changes

nothingmin force-pushed the fix/54134 branch 2 times, most recently from 3eddcd7 to cd79bc1 Compare September 2, 2025 14:39

nothingmin requested review from Fokko, amoghrajesh, ashb, bbovenzi, bolkedebruin, eladkal, gopidesupavan, hussein-awala, jedcunningham, kaxil, mik-laj and potiuk as code owners September 2, 2025 14:39

pierrejeambrun mentioned this pull request Sep 4, 2025

UI - Grid invalidation on TI Action #55267

Closed

pierrejeambrun merged commit f5d0b17 into apache:main Sep 4, 2025
107 checks passed

pierrejeambrun pushed a commit to astronomer/airflow that referenced this pull request Sep 4, 2025

Fix clearTaskInstances API: Restore include_past/future support on UI (…

eb8b152

…apache#54416)

pierrejeambrun mentioned this pull request Sep 4, 2025

Fix clearTaskInstances API: Restore include_past/future support on UI… #55272

Merged

pierrejeambrun added a commit that referenced this pull request Sep 5, 2025

Fix clearTaskInstances API: Restore include_past/future support on UI (…

583266c

…#54416) (#55272) Co-authored-by: Gwak Beomgyu <67548026+nothingmin@users.noreply.github.com>

kaxil modified the milestones: Airflow 3.0.7, Airflow 3.1.0 Sep 13, 2025

Conversation

nothingmin commented Aug 12, 2025

Uh oh!

boring-cyborg bot commented Aug 12, 2025

Uh oh!

pierrejeambrun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nothingmin commented Aug 20, 2025

Uh oh!

pierrejeambrun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pierrejeambrun commented Sep 4, 2025

Uh oh!

pierrejeambrun commented Sep 4, 2025

Uh oh!

Uh oh!

boring-cyborg bot commented Sep 4, 2025

Uh oh!

github-actions bot commented Sep 4, 2025

Backport failed to create: v3-0-test. View the failure log Run details

Uh oh!

pierrejeambrun commented Sep 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants